Re: [PATCH 1/3] mfd: ab8500-debugfs: Apply a check for -ENOMEM afterallocating memory for sysfs

From: Lee Jones
Date: Tue Aug 27 2013 - 06:40:47 EST


On Fri, 19 Jul 2013, Lee Jones wrote:

> The AB8500 debugfs driver allocates memory for a new sysfs entry, but
> fails to apply the proper post-allocation checks. If the device were to
> run out of memory, the allocation would return NULL. Without the correct
> checks the driver will continue to populate NULL->[show|store|...],
> which would obviously cause a pointer dereference Oops.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/mfd/ab8500-debugfs.c | 3 +++
> 1 file changed, 3 insertions(+)

These 3 patches have been on the MLs for quite some time now.

Tentatively applying all 3.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/