Re: [PATCH 0/3] perf ui/gtk: Separate out GTK code to a shared object (v4)

[Namhyung Kim]

Hi Arnaldo,

Sorry for late reply.

On Mon, 19 Aug 2013 12:17:34 -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Aug 19, 2013 at 11:05:00AM -0300, Arnaldo Carvalho de Melo escreveu:
>> But I expected that after the first patch 'perf --gtk' would work, and
>> it doesn't.
>> 
>> Now even after I applied the whole series I don't get --gtk to work,
>> neither as a non-root nor as root :-\
>> 
>> Investigating...
>
> Somehow I expected ~/lib64/ was in the ld library path, it was not, duh,
> after I added it, and applied all three patches, it works as expected,
> so can we:
>
> 1. combine the three patches into just one so that we keep the 'perf
> report --gtk' bisectable?
>
> 2. add a patch to warn the user when '--gtk' is specified but no
>    libperf-gtk.so file is found in the loader library path?

Hmm.. makes sense.  I'll do the option 1 (include the warning).

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/