Re: [PATCH] USB: OHCI: fix build error related to ohci_suspend/resume

[Guenter Roeck]

On Mon, Aug 26, 2013 at 03:14:14PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Aug 26, 2013 at 10:19:03AM -0700, Guenter Roeck wrote:
> > On Mon, Aug 26, 2013 at 09:50:22AM -0700, Greg Kroah-Hartman wrote:
> > > On Mon, Aug 26, 2013 at 09:06:27AM -0700, Guenter Roeck wrote:
> > > > On Mon, Aug 26, 2013 at 08:38:40AM -0700, Greg Kroah-Hartman wrote:
> > > > > On Mon, Aug 26, 2013 at 10:53:53AM -0400, Alan Stern wrote:
> > > > > > Commit 9a11899c5e69 (USB: OHCI: add missing PCI PM callbacks to
> > > > > > ohci-pci.c) added missing ohci_suspend and ohci_resume callback
> > > > > > pointers, but forgot that these callbacks are declared and defined
> > > > > > only when CONFIG_PM is enabled.
> > > > > > 
> > > > > > This patch adds a preprocessor conditional to avoid build errors when
> > > > > > PM is disabled.
> > > > > > 
> > > > > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > > > > > 
> > > > > > ---
> > > > > 
> > > > > Guenter and Meelis, does the patch below fix the problem for you?
> > > > > 
> > > > Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > > 
> > > > Previously failing builds:
> > > > 	mips:ath79_defconfig
> > > > 	powerpc:ppc64e_defconfig
> > > > 	powerpc:cell_defconfig
> > > > 	powerpc:maple_defconfig
> > > > 	parisc:defconfig
> > > > 	tile:defconfig
> > > > 	sparc32:defconfig
> > > > 	sparc64:defconfig
> > > > 
> > > > 	as well as the powerpc qemu test (with the config file used
> > > > 	by the yocto project)
> > > > 
> > > > All builds pass with the patch applied, as does the qemu test.
> > > 
> > > Thanks for testing, I'll queue it up later today (at an airport right
> > > now, about to board a flight), and send it to Linus later tonight if no
> > > one else has any problems with it.
> > > 
> > To simplify this kind of testing, I added a 'testing' branch to the list of
> > branches I am auto-building. Right now it runs a complete test cycle with the
> > patch applied on top of v3.11-rc7. This should ensure that the patch doesn't
> > break any previously passing builds. You should see the results in the 'testing'
> > column of the stable queue build table on http://server.roeck-us.net:8010/builders
> > when you get out of the plane.
> 
> Thanks, all looks good, except for xtensa, which says I broke something,
> but I can't understand what, as I don't see any networking patches in my
> tree at the moment. 
> 
That has been broken in Linus' tree for a while - at least since I started
running my test builds. I don't understand xtensa good enough to know how
to fix it. I have seen similar problems before, though, so I suspect it has
something to do with the architecture and not with the affected file itself.

I submitted a patch to fix the broken arm:allmodconfig build. Hopefully
it should find its way into Linus' tree in the near future.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/