Re: [3.10][PATCH 4/4] mei: me: fix hardware reset flow

From: Greg KH
Date: Mon Aug 26 2013 - 17:43:54 EST


On Sun, Aug 25, 2013 at 12:49:49PM +0300, Tomas Winkler wrote:
> stable: 3.10
> commit ff96066e3171acdea356b331163495957cb833d0 char-misc

Sorry, but I have to wait until the patch hits Linus's tree before I can
accept it into a stable tree, you know that :(

> Both H_IS and H_IE needs to be set to receive H_RDY
> interrupt
>
> 1. Assert H_IS to clear the interrupts during hw reset
> and use mei_me_reg_write instead of mei_hcsr_set as the later
> strips down the H_IS
>
> 2. fix interrupt disablement embarrassing typo
> hcsr |= ~H_IE -> hcsr &= ~H_IE;
> this will remove the unwanted interrupt on power down
>
> 3. remove useless debug print outs
>
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Shuah Khan <shuah.kh@xxxxxxxxxxx>
> Cc: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Conflicts:
> drivers/misc/mei/hw-me.c

What's this for?

I'll wait for this to hit Linus's tree during the 3.12-rc1 merge window
and then add it to the 3.10-stable tree, ok?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/