Re: [PATCH] nbd: correct disconnect behavior

From: Pavel Machek
Date: Mon Aug 26 2013 - 08:55:34 EST


Hi!

> >> --- a/include/linux/nbd.h
> >> +++ b/include/linux/nbd.h
> >> @@ -41,6 +41,7 @@ struct nbd_device {
> >> u64 bytesize;
> >> pid_t pid; /* pid of nbd-client, if attached */
> >> int xmit_timeout;
> >> + int disconnect; /* a disconnect has been requested by user */
> >> };
> >
> >The cool kids are using bool lately ;)
>
> No, they're not. The C++ guys and stuffy old ex-cobol types are, and
> think it helps. (Does any architecture anywhere _not_ use int for
> bool?)

Its useful as documentation, and while it is probably int,
faster/smaller code can probably generated in some cases.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/