Re: [PATCH 0/4 v6] Avoid softlockups in console_unlock()

From: Jiri Kosina
Date: Mon Aug 26 2013 - 07:48:32 EST


On Fri, 23 Aug 2013, Andrew Morton wrote:

> > > > We have customers (quite a few of them actually) which have machines with
> > > > lots of SCSI disks attached (due to multipath etc.) and during boot when
> > > > these disks are discovered and partitions set up quite some printing
> > > > happens - multiplied by the number of devices (1000+) it is too much for a
> > > > serial console to handle quickly enough. So these machines aren't able to
> > > > boot with serial console enabled.
> > >
> > > It sounds like rather a corner case, not worth mucking up the critical
> > > core logging code.
> >
> > Andrew, I have to admit I don't understand this argument at all.
>
> Of course you do. print should be simple, robust and have minimum
> dependency on other kernel parts.

I agree. That would need a complete printk() rewrite though. Before that
happens, fixing obvious lockup in the code seems like a very proper thing
to do.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/