Re: [PATCH v2 4/4] pinctrl: mvebu: Convert to usedevm_ioremap_resource

[Jisheng Zhang]

Hi Ezequiel,

On Sat, 24 Aug 2013 08:06:25 -0700
Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx> wrote:

> Hi Jisheng,
> 
> On Fri, Aug 23, 2013 at 10:34:02AM +0800, Jisheng Zhang wrote:
> > Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> > ---
> >  drivers/pinctrl/mvebu/pinctrl-mvebu.c | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> > 
> 
> Mmm.. I would prefer to see a better commit log for this patch.
> In particular, the current code is buggy (for there's a leak) and
> this patch fixes it.
> Care to write something meaningful and re-send? (except the patch

Done. Could you please review again?

> Mike already took, I guess).
> 
> With that changes you can add:
> 
> Reviewed-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx>T
Thank you for your help
> 
> for the whole series.

Best Regards,
Jisheng


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/