Re: linux-next: Tree for Aug 21 [ screen corruption in graphical mode ]

From: Sedat Dilek
Date: Sat Aug 24 2013 - 05:35:11 EST


On Fri, Aug 23, 2013 at 10:34 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Aug 23, 2013 at 10:04:37AM +0200, Sedat Dilek wrote:
>> On Fri, Aug 23, 2013 at 9:55 AM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>> > On Thu, Aug 22, 2013 at 1:32 PM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
>> >> On Thu, Aug 22, 2013 at 1:30 PM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
>> >>> On Thu, Aug 22, 2013 at 1:13 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>> >>>> dmesg (a lot of traces) and kernel-config attached.
>> >>>>
>> >>>> UXA causes still screen corruption.
>> >>>
>> >>> Hm, was only a slim chance that this patch would fix anything - I
>> >>> think you'd always see an oops when you'd hit this bug instead of just
>> >>> a bit of corruption.
>> >>
>> >> Ok, I think it's time to throw in the towel a bit. I've dropped
>> >>
>> >>
>> >> commit d46f1c3f1372e3a72fab97c60480aa4a1084387f
>> >> Author: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> >> Date: Thu Aug 8 14:41:06 2013 +0100
>> >>
>> >> drm/i915: Allow the GPU to cache stolen memory
>
> Hmm, wrong patch. Unless you have a good reason, you just want to drop
> the ringbuffers in stolen.
>
>> >> from my queue. I guess we can retry for 3.13 again.

Just to clarify...

I pulled in today's d-i-n (e1a7374a9920cbbb085ca310e50c903d182d1ca9)
on top of Linus-git HEAD (v3.11-rc6-139-g89b53e5).

This is the list of drm/i915 patches containing "stolen":

drm/i915: Free stolen node on failed preallocation
drm/i915: Verify that our stolen memory doesn't conflict
drm/i915: Use Graphics Base of Stolen Memory on all gen3+
drm/i915: List objects allocated from stolen memory in debugfs
drm/i915: Allow the GPU to cache stolen memory <--- *** NOT DROPPED ***
drm/i915: less magic for stolen preallocated objects w/o gtt offset
drm/i915: WARN if the bios reserved range is bigger than stolen size
drm/i915: disable stolen mem for OVERLAY_NEEDS_PHYSICAL
drm/i915: clarify error paths in create_stolen_for_preallocated

So the culprit patch "drm/i915: Allocate LLC ringbuffers from stolen"
seems to be gone.
I have not compared against my other cumulated patches.
As far as I understood Daniel he dropped a patchset, but I might have
understood him wrong.

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/