Re: [PATCH v1 1/2] perf: add attr->mmap2 attribute to an event

[Stephane Eranian]

On Mon, Aug 19, 2013 at 11:14 AM, Stephane Eranian <eranian@xxxxxxxxxx> wrote:
> On Thu, Aug 15, 2013 at 12:26 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>> On Tue, Aug 13, 2013 at 01:55:56PM +0200, Stephane Eranian wrote:
>>
>>> @@ -638,6 +639,25 @@ enum perf_event_type {
>>>        */
>>>       PERF_RECORD_SAMPLE                      = 9,
>>>
>>> +     /*
>>> +      * The MMAP2 records are an augmented version of MMAP, they add
>>> +      * maj, min, ino numbers to be used to uniquely identify each mapping
>>> +      *
>>> +      * struct {
>>> +      *      struct perf_event_header        header;
>>> +      *
>>> +      *      u32                             pid, tid;
>>> +      *      u64                             addr;
>>> +      *      u64                             len;
>>> +      *      u64                             pgoff;
>>> +      *      u32                             maj;
>>> +      *      u32                             min;
>>> +      *      u64                             ino;
>>> +      *      char                            filename[];
>>
>> Did you forget the sample_id stuff?
>>
>>                 struct sample_id                sample_id;
>>
> Ok, will add that and the i_generation field.

Added that now, works fine. Except it won't be availa when synthesizing
MMAP records from /proc/PID/maps because it is not displayed there.
There is not much we can do about this. And of course, there is not i_generation
for kernel level ELF images.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/