Re: Why are BSD-licensed LZ4 symbols GPL exported?

[Joe Perches]

On Tue, 2013-08-20 at 14:46 -0700, Joe Perches wrote:
> Because your

Sorry, not your's but Matthew's.

I do think the MODULE_LICENSE should be "Dual BSD/GPL"
instead of merely "GPL" if for no other reason than
politeness to the original developer and the
license at the top of the files.

 * LZ4 - Fast LZ compression algorithm
 * Copyright (C) 2011-2012, Yann Collet.
 * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php)

---
 lib/lz4/lz4_compress.c   | 2 +-
 lib/lz4/lz4_decompress.c | 2 +-
 lib/lz4/lz4hc_compress.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/lz4/lz4_compress.c b/lib/lz4/lz4_compress.c
index fd94058..a4001ee 100644
--- a/lib/lz4/lz4_compress.c
+++ b/lib/lz4/lz4_compress.c
@@ -439,5 +439,5 @@ exit:
 }
 EXPORT_SYMBOL_GPL(lz4_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 compressor");
diff --git a/lib/lz4/lz4_decompress.c b/lib/lz4/lz4_decompress.c
index d3414ea..c45e685 100644
--- a/lib/lz4/lz4_decompress.c
+++ b/lib/lz4/lz4_decompress.c
@@ -321,6 +321,6 @@ exit_0:
 #ifndef STATIC
 EXPORT_SYMBOL_GPL(lz4_decompress_unknownoutputsize);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 Decompressor");
 #endif
diff --git a/lib/lz4/lz4hc_compress.c b/lib/lz4/lz4hc_compress.c
index eb1a74f..59f26e6 100644
--- a/lib/lz4/lz4hc_compress.c
+++ b/lib/lz4/lz4hc_compress.c
@@ -535,5 +535,5 @@ exit:
 }
 EXPORT_SYMBOL_GPL(lz4hc_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4HC compressor");


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/