On 08/16/2013 04:13 AM, George Cherian wrote:Adding extcon driver for USB ID detection to dynamicallyPlease at lest explain what a DRA7xxx is, and the purpose of the HW
configure USB Host/Peripheral mode.
diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt
+EXTCON FOR DRA7xx
+
+Required Properties:
module this binding describes.
+ - compatible : Should be "ti,dra7xx-usb"If this is a USB VID detector rather than a full USB host controller,
then "usb" in the binding is a bit over-reaching. Perhaps "-usb-vid" or
"-usb-vid-detector" would be more accurate.
+ - gpios : phandle to ID pin and interrupt gpio.This isn't just a phandle; it's phandle+args, or a GPIO specifier. Some
reference should be made to ../gpio/gpio.txt for the format.
Why does the interrupt line need to be included in a list of GPIOs?
If the DRA7xxx is a VID detector, why does it even need/have any GPIOs
associated with it; surely it has a dedicated VID input pin. Can you
provide more details re: how the HW is structured.
+Optional Properties:It's typical insert the following between those two blank lines:
+ - interrupt-parent : interrupt controller phandle
+ - interrupts : interrupt number
+
+
Example:
... or delete one of the blank lines.
+dra7x_extcon1 {No need for that trailing blank line.
+ compatible = "ti,dra7xx-usb";
+ gpios = <&pcf_usb 1 0>,
+ <&gpio6 11 2>;
+ interrupt-parent = <&gpio6>;
+ interrupts = <11>;
+ };
+