Re: [PATCH 2/2] cpuset: remove redundant checks in file write functions

[Li Zefan]

On 2013/8/14 21:30, Tejun Heo wrote:
> Hello, Li.
> 
> On Wed, Aug 14, 2013 at 10:01:32AM +0800, Li Zefan wrote:
>> But most controllers don't check this in those read/write functions.
>> It shoudn't do any harm not checking online/offline status.
> 
> It depends on the specific controller.  For controllers which make
> clear distinction between online and offline states for, say,
> hierarchical config propagation, it could lead to buggy behavior if
> the function body afterwards assume that the current node is online.

In those cases, there must be some comments, otherwise it would be
confusing if and when one needs to check the online/offline states.

> I don't know whether this is the case for the functions converted here
> but even if so the patch needs to update the description.
> 

I'll check for sure.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/