Re: [PATCH 1/3] misc: Add crossbar driver

From: Santosh Shilimkar
Date: Thu Aug 15 2013 - 16:27:50 EST

On Thursday 15 August 2013 04:01 PM, Linus Walleij wrote:
> On Tue, Aug 13, 2013 at 11:56 AM, Sricharan R <r.sricharan@xxxxxx> wrote:
>> Initially irqchip was discussed, but we also have a DMA crossbar
>> to map the dma-requests. Since both irq/dma crossbars should be handled,
>> pinctrl was suggested as the appropriate place to handle this.
> I think it is better to use irqchip.
Did you happen to read the thread why irqchip is in-appropriate
for such an IP. As I said earlier, an IRQ-chip always need a
real IRQ link (even for the chained one) to the primary irqchip.

This IP is just dummy IP makes the connections for the primary
irqchip(read GIC). And its use only limited to make the
connection between the peripheral IRQ event to the GIC IRQ line.

I don't see how you can make this happen with an irqchip

If you have a idea to make that work, we can go with that
since for time being we can ignore the DMA event related need
of this IP.

> For DMA there is already an arbiter mechanism for arbitration of
> virtual channels over physical channels, this is not much different,
> the DMA might need some different tweaking but should be solved
> in that subsystem I think.
Sure. The IP won't be limited to DMA and IRQ lines but any other events
like gpio etc in future.

> I don't see any way to really abstract this pretty simple crossbar
> for reuse across subsystems.
This exactly the reason, i am against idea of over-engineering the
simple IP whose only job is to make the physical wire connection
in software where as this is generally done in RTL by default on
most of the SOCs.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at