Re: [PATCH 20/29] watchdog: s3c2410_wdt: simplify use of devm_ioremap_resource

From: Guenter Roeck
Date: Wed Aug 14 2013 - 23:19:48 EST

On 08/14/2013 02:11 AM, Julia Lawall wrote:
From: Julia Lawall <Julia.Lawall@xxxxxxx>

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.

A simplified version of the semantic patch that makes this change is as
follows: (

// <smpl>
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at