Re: [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtkexecutable

From: Ingo Molnar
Date: Wed Aug 14 2013 - 10:21:04 EST

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx> wrote:

> Em Tue, Aug 13, 2013 at 05:57:16PM -0400, Vince Weaver escreveu:
> > On Tue, 13 Aug 2013, Ingo Molnar wrote:
> >
> > > that can only be addressed by either extending 'perf test' or by
> > > testing libpfm et al sooner. The upstream kernel can only address
> > > regressions that get reported.
> > Most of the tests in my test-suite are reactive. Meaning, I wrote
> > them after an ABI-breaking change was reported elsewhere, and I needed
> > a small test case for bisection purposes. Thus they are good for
> > finding if a corner of the perf ABI re-breaks but they're not great at
> > spotting new breakages.

Would be nice to merge those in into 'perf test' - reactive tests are
useful as well IMO.

> > Writing a complete test suite for something as complicated as the
> > perf-event ABI is impractical. One thing you can do is require anyone
> > submitting new functionality also provide a regression test, but
> Agreed.
> > I don't see that happening.
> See some of Namhyung, Adrian and Jiri recent patchsets, they came with
> 'perf test' regression tests.

That's good progress indeed! If we merge in the cases that Vince found
then we'd have good practical coverage and we could also start requiring
good testcases for every new ABI extension.

That method distributes the overhead of having to write it to those who
want to extend (and, statistically speaking, inadvertantlybreak!) the ABI.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at