[PATCH 65/75] ALSA: usb/6fire: Fix potential NULL pointer dereference in comm.c

From: Luis Henriques
Date: Wed Aug 14 2013 - 06:38:40 EST -stable review patch. If anyone has any objections, please let me know.


From: Sachin Kamat <sachin.kamat@xxxxxxxxxx>

commit 27b2a22c714303d1920e269a8322ff23107694ee upstream.

'rt' was dereferenced before the NULL check.
Moved the code after the check.

Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Luis Henriques <luis.henriques@xxxxxxxxxxxxx>
sound/usb/6fire/comm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/usb/6fire/comm.c b/sound/usb/6fire/comm.c
index 6c3d531..1a75c36 100644
--- a/sound/usb/6fire/comm.c
+++ b/sound/usb/6fire/comm.c
@@ -129,12 +129,13 @@ int __devinit usb6fire_comm_init(struct sfire_chip *chip)
struct comm_runtime *rt = kzalloc(sizeof(struct comm_runtime),
- struct urb *urb = &rt->receiver;
+ struct urb *urb;
int ret;

if (!rt)
return -ENOMEM;

+ urb = &rt->receiver;
rt->serial = 1;
rt->chip = chip;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/