Re: [ 00/17] 3.4.58-stable review

[Geert Uytterhoeven]

On Wed, Aug 14, 2013 at 12:36 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>> > cris/...:
>> > In file included from include/linux/page-flags.h:8:0,
>> >                  from kernel/bounds.c:9:
>> > include/linux/types.h:25:1: error: unknown type name '__kernel_ino_t'
>> > include/linux/types.h:29:1: error: unknown type name '__kernel_off_t'
>> > include/linux/types.h:30:1: error: unknown type name '__kernel_pid_t'
>> > include/linux/types.h:31:1: error: unknown type name '__kernel_daddr_t'
>> > include/linux/types.h:33:1: error: unknown type name '__kernel_suseconds_t'
>> >
>> > That one might be tricky (or simple if someone knows what is wrong).
>>
>> Fixed in v3.5-rc1:
>>
>> commit 74f077d2a7651409c44bb323471f219a4b0d2aab
>> Author: Jiri Slaby <jslaby@xxxxxxx>
>> Date:   Mon Apr 2 13:40:17 2012 +0200
>>
>>     cris: posix_types.h, include asm-generic/posix_types.h
>>
> It does fix above error, but then there is another error:
>
>   AS      arch/cris/arch-v10/lib/checksum.o
> In file included from <command-line>:4:0:
> /home/groeck/src/linux-stable/include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
> make[1]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
>   AS      arch/cris/arch-v10/lib/checksumcopy.o
> In file included from <command-line>:4:0:
> /home/groeck/src/linux-stable/include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
> make[1]: *** [arch/cris/arch-v10/lib/checksumcopy.o] Error 1

commit 7b91747d42a1012e3781dd09fa638d113809e3fd
Author: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Date:   Wed Apr 18 21:58:43 2012 +0200

    cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile

    Most of these have been purged years ago.  This one silently lived
    on until commit 69349c2dc01c489eccaa4c472542c08e370c6d7e

        "kconfig: fix IS_ENABLED to not require all options to be defined"

    In the above, we use some macro trickery to create a conditional that
    is valid in CPP and in C usage.  However that trickery doesn't sit
    well if you have the legacy "-traditional" flag enabled.  You'll get:

      AS      arch/cris/arch-v10/lib/checksum.o
    In file included from <command-line>:4:0:
    include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
    make[2]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1

    Everything builds fine w/o "-traditional" so simply drop it from this
    location as well.

    Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
    Signed-off-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/