Re: [PATCH 1/8] x86: Add 1/2/4/8 byte optimization to 64bit __copy_{from,to}_user_inatomic

From: Linus Torvalds
Date: Tue Aug 13 2013 - 20:17:59 EST


On Tue, Aug 13, 2013 at 5:07 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>
> 32bit already did this correctly by duplicating the code.

I wonder how much of this could be in asm/uaccess.h? We already do all
the fixed-size get_user/put_user stuff in that generic x86 code, and
I'm wondering why we don't do the "__builtin_constant_p()" cases of
copy_to/from_user() there too?

It's independent of this patch-series, but it might be good to take a
look at unifying these things..

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/