Re: [PATCH 10/10] staging: ozwpan: Separate success & failure casefor oz_hcd_pd_arrived()

From: Dan Carpenter
Date: Tue Aug 13 2013 - 19:00:33 EST

On Tue, Aug 13, 2013 at 06:29:26PM +0100, Rupesh Gujare wrote:
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> This patch separates success & failure block along with fixing
> following issues:-
> 1. The way oz_hcd_pd_arrived() looks now it's easy to think we free "ep" but
> actually we do this spaghetti thing of setting it to NULL on success.
> 2. It is hard to read it because there are unlocks scattered throughout.
> 3. Currently we set "ep" to NULL on the success path and then test it and or
> free it. In current code you have to scroll to the start of the function
> to read code.
> Original patch was submitted by Dan here :-
> Signed-off-by: Rupesh Gujare <rupesh.gujare@xxxxxxxxx>

Since you gave me the author tag for this then I'll sign off on this
as well.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at