Re: [PATCH] PM / QoS: Fix workqueue deadlock when using pm_qos_update_request_timeout()

From: Rafael J. Wysocki
Date: Tue Aug 13 2013 - 18:44:02 EST


On Tuesday, August 13, 2013 06:13:25 PM Tejun Heo wrote:
> Hello,
>
> On Tue, Aug 13, 2013 at 02:12:40PM -0700, Stephen Boyd wrote:
> > @@ -308,7 +319,7 @@ static void pm_qos_work_fn(struct work_struct *work)
> > struct pm_qos_request,
> > work);
> >
> > - pm_qos_update_request(req, PM_QOS_DEFAULT_VALUE);
> > + __pm_qos_update_request(req, PM_QOS_DEFAULT_VALUE);
>
> Maybe a short comment explaining why this is different would be nice?
> Other than that,
>
> Reviewed-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks guys, I'm going to push that as a fix for 3.11-rc6 and stable.

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/