Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

[Mark Rutland]

On Mon, Aug 12, 2013 at 07:05:53PM +0100, Felipe Balbi wrote:
> On Fri, Aug 09, 2013 at 01:42:15PM -0500, Kumar Gala wrote:
> > 
> > On Aug 9, 2013, at 11:28 AM, Mark Rutland wrote:
> > 
> > > On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote:
> > >> The binding spec wasn't clear that the order of the phandles in the
> > >> usb-phy array has meaning.  Clarify this point in the binding that
> > >> it should be <USB2-HS-PHY, USB3-SS-PHY>.
> > >> 
> > >> Signed-off-by: Kumar Gala <galak@xxxxxxxxxxxxxx>
> > >> ---
> > >> Documentation/devicetree/bindings/usb/dwc3.txt | 4 +++-
> > >> 1 file changed, 3 insertions(+), 1 deletion(-)
> > >> 
> > >> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> > >> index 7a95c65..8a9770b 100644
> > >> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> > >> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> > >> @@ -6,7 +6,9 @@ Required properties:
> > >>  - compatible: must be "synopsys,dwc3"
> > >>  - reg : Address and length of the register set for the device
> > >>  - interrupts: Interrupts used by the dwc3 controller.
> > >> - - usb-phy : array of phandle for the PHY device
> > >> + - usb-phy : array of phandle for the PHY device.  The first element
> > >> +   in the array is expected to be a handle to the USB2/HS PHY and
> > >> +   the second element is expected to be a handle to the USB3/SS PHY
> > > 
> > > Just to check - it's not valid to have a USB3 phy without a USB2 phy?
> > 
> > Don't know, hopefully Felipe will chime in on that.
> 
> that'd be a really non-standard implementation. Per-spec, USB3 is
> *always* backwards compatible with USB2.

I'm slightly confused here. From a quick look at the driver, it expects
two separate phys to be present -- one handling only USB2, and one
handling USB3 (with USB2 backwards compatibility).

So it's not physically possible for someone to just wire up a single phy
to the device, either USB2-only or USB3?

You can describe the USB2-only case in the dt by only listing the first
phy (though the driver won't support it as it expects both to be
present), but it's impossible to describe that you've wired up a single
phy that's USB3 capable.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/