Re: [PATCH 33/35] power: use dev_get_platdata()

[Dan Carpenter]

On Mon, Aug 12, 2013 at 09:22:42AM +0900, Jingoo Han wrote:
> On Saturday, August 10, 2013 7:05 AM, Anton Vorontsov wrote:
> > On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote:
> > > Use the wrapper function for retrieving the platform data instead of
> > > accessing dev->platform_data directly.
> > 
> > Um.. what is the benefit or rationale of this patch?
> 
> CC'ed Joe Perches, Dan Carpenter
> 
> Hi Anton Vorontsov,
> 
> Usually, using the wrapper function makes the code simpler.
> Also, it make the code more readable.

Since people are asking my opinion, then yes using
dev_get_platdata() as intended is better than open coding.  It's a
coding standard thing.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/