Re: [PATCH] x86: selective remapping in parse_setup_data()

From: H. Peter Anvin
Date: Mon Aug 12 2013 - 17:08:59 EST


On 08/12/2013 02:00 PM, Linn Crosetto wrote:
> PCI devices may advertise a ROM size larger than early_memremap() is
> able to handle. If this occurs it leads to a NULL dereference in
> parse_setup_data(). Avoid this by remapping the data only when
> necessary.
>
> Signed-off-by: Linn Crosetto <linn@xxxxxx>

I think you need to clarify the various subcases (the code looks right,
but the explanation needs to be improved.)

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/