Re: [PATCH 10/13] x86: Move cond resched for copy_{from,to}_userinto low level code 64bit

From: JÃrn Engel
Date: Sat Aug 10 2013 - 16:39:18 EST

On Sat, 10 August 2013 20:23:09 +0200, Borislav Petkov wrote:
> Sounds like the debug aspect and the preemption point addition need
> to be sorf-of split into two different functions/macros and each used
> separately.
> Something like keep the current might_sleep and have debug_sleep or
> similar which does only __might_sleep without the resched...

I would argue for using "might_sleep" for the debug variant. Before
reading this thread I wasn't even aware of the non-debug aspect.
After all, might_sleep naturally reads like some assertion.
"might_preempt" for the non-debug version? "cond_preempt"?


It is the mark of an educated mind to be able to entertain a thought
without accepting it.
-- Aristotle
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at