Re: [PATCH 20/23] thp: handle file pages in split_huge_page()

[Kirill A. Shutemov]

Ning Qu wrote:
> I just tried, and it seems working fine now without the deadlock anymore. I
> can run some big internal test with about 40GB files in sysv shm. Just move
> the line before the locking happens in vma_adjust, something as below, the
> line number is not accurate because my patch is based on another tree right
> now.

Looks okay to me. Could you prepare real patch (description, etc.). I'll
add it to my patchset.

> 
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -581,6 +581,8 @@ again:                      remove_next = 1 + (end >
> next->vm_end);
>                 }
>         }
> 
> +       vma_adjust_trans_huge(vma, start, end, adjust_next);
> +
>         if (file) {
>                 mapping = file->f_mapping;
>                 if (!(vma->vm_flags & VM_NONLINEAR))
> @@ -597,8 +599,6 @@ again:                      remove_next = 1 + (end >
> next->vm_end);
>                 }
>         }
> 
> -       vma_adjust_trans_huge(vma, start, end, adjust_next);
> -
>         anon_vma = vma->anon_vma;
>         if (!anon_vma && adjust_next)
>                 anon_vma = next->anon_vma;
> 
> 
> Best wishes,
> -- 
> Ning Qu (��) | Software Engineer | quning@xxxxxxxxxx | +1-408-418-6066

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/