Re: [PATCH 04/22] block: Abstract out bvec iterator

From: Kent Overstreet
Date: Thu Aug 08 2013 - 20:09:54 EST

On Wed, Aug 07, 2013 at 10:04:36PM -0400, Ed Cashin wrote:
> On Aug 7, 2013, at 5:54 PM, Kent Overstreet wrote:
> > Immutable biovecs are going to require an explicit iterator. To
> > implement immutable bvecs, a later patch is going to add a bi_bvec_done
> > member to this struct; for now, this patch effectively just renames
> > things.
> Hi, Kent Overstreet. Thanks for Cc'ing me and for the promising work.
> Were you able to do sanity tests with aoe this time around? Last time, basic I/O was not working with the immutable biovec patches applied.
> Here is my 28 June email about my experiences with git:// at that time. It also includes information about creating an easy software-only aoe test environment.

Hey, thanks for testing it - sorry, I think I remember seeing that email
last time and got sidetracked before I got around to setting up some

I think I've got it working now, it's running the same stress tests I
use for bcache. Here's a fixed patch, I broke the aoe changes out into
their own patch since they were more involved than most of the others:

(I am seeing a bug where it's getting stuck after running stress tests
for awhile, but I can reproduce that without the aoe changes too...)