Re: [PATCH v2 1/3] leds-pca9633: Add support for PCA9634

From: Bryan Wu
Date: Thu Aug 08 2013 - 18:49:43 EST

On Thu, Aug 8, 2013 at 3:36 PM, Peter Meerwald
<p.meerwald@xxxxxxxxxxxxxxxxxx> wrote:
> Hello,
>> > Add support for PCA9634 chip, which belongs to the same family as the
>> > 9633 but with support for 8 outputs instead of 4.
>> Basically I like this method to add a new chip supporting. Please find
>> my comments below.
> me too :)
>> What about just rename the whole file to leds-pca963x.c. And rename
>> some pca9633 to pca963x in the driver.
> there are other, similar I2C LED driver chips which might be
> handled with the current pca9633 driver, e.g. the pca9685 (which is
> supported under pwm/ by the way)
> people have argued that the numbering scheme of chips is hard to
> predict; hence, the driver name should be determined by the first
> device supported to avoid subsequent renaming -- but I have no strong
> feelings about this

Giving a more generic and meaningful name of this driver should be a
easier for people to understand. So if pca9685 is coming, we can use
leds-pca96xx.c and pca96xx for this pca96xx chip family, as long as
they can share this driver code.

Please take a look at Milo did in leds-lp55xx drivers.

Thanks a lot,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at