Re: [PATCH 22/23] thp, mm: split huge page on mmap file page

[Khalid Aziz]

On Sun, 2013-08-04 at 05:17 +0300, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
> 
> We are not ready to mmap file-backed tranparent huge pages. Let's split
> them on fault attempt.
> 
> Later we'll implement mmap() properly and this code path be used for
> fallback cases.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> ---
>  mm/filemap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index ed65af5..f7857ef 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -1743,6 +1743,8 @@ retry_find:
>  			goto no_cached_page;
>  	}
>  
> +	if (PageTransCompound(page))
> +		split_huge_page(compound_trans_head(page));

Since PageTransCompound(page) returns true for transparent huge pages as
well as hugetlbfs pages, could this code split hugetlbfs pages on an
mmap() on to hugetlbfs pages? hugetlbfs pages are not supposed to be
split, right?

>  	if (!lock_page_or_retry(page, vma->vm_mm, vmf->flags)) {
>  		page_cache_release(page);
>  		return ret | VM_FAULT_RETRY;

--
Khalid

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/