Re: [PATCH 3/5] x86, AMD: cleanup: merge common code in earlymicrocode loading

From: Borislav Petkov
Date: Thu Aug 08 2013 - 13:49:14 EST


On Wed, Aug 07, 2013 at 11:34:01PM +0000, Yu, Fenghua wrote:
> > This check won't work when CPU0 is hot added. So we need to find a
> > better way to fix this.
> >
>
> Maybe need to change the check as follows to take care of CPU0 hot add case?
>
> if ((cpu && system_state == SYSTEM_BOOTING) || (system_state == SYSTEM_RUNNING))
> load_ucode_ap();

Ok, just for my own understanding - I haven't played with cpu hotadd yet
so when you do this, is the hot-added socket containing the BSP not cpu
0 anymore?

Or when you hot-remove the socket containing the BSP, another AP becomes
the BSP and preserves its old number?

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/