Re: [PATCH 3/3 V2] EDAC, AMD64_EDAC: Add ECC decoding support fornewer F15h models.

[Aravind Gopalakrishnan]

> > >           addr -= 0x100;
> > >       }
> > >   @@ -205,8 +213,9 @@ static int amd64_set_scrub_rate(struct 
> > > mem_ctl_info *mci, u32 bw)
> > >       if (boot_cpu_data.x86 == 0xf)
> > >           min_scrubrate = 0x0;
> > >   -    /* F15h Erratum #505 */
> > > -    if (boot_cpu_data.x86 == 0x15)
> > > +    /* F15h Models 0x00 - 0x0f Erratum #505 */
> > Hmm, are you sure this erratum is fixed in SR? Talk to Eric about it
> > first, please. RG says "No fix planned".
> >
> > > +    if (boot_cpu_data.x86 == 0x15 &&
> > > +        boot_cpu_data.x86_model != 0x30)
> > >           f15h_select_dct(pvt, 0);
> > >         return __amd64_set_scrub_rate(pvt->F3, bw, min_scrubrate);
> > > @@ -218,8 +227,9 @@ static int amd64_get_scrub_rate(struct 
> > > mem_ctl_info *mci)
> > >       u32 scrubval = 0;
> > >       int i, retval = -EINVAL;
> > >   -    /* F15h Erratum #505 */
> > > -    if (boot_cpu_data.x86 == 0x15)
> > > +    /* F15h Models 0x00 - 0x0f Erratum #505 */
> > ditto.
>
> I have pinged some people about it, will let you know..
From email conversations internally, here are the current status of the 
errata:
* Erratum 505: Should not be carried over to newer Fam15h models.
* Erratum 637: Not fixed.

I have taken this into account and changed the code to workaround only E637.

> will send out changes in V3;
>
> Thanks,
> Aravind.
Corrected the indentations; Removed unnecessary comments;
Sending out changes in  [PATCH 3/3 V3].
Thanks,
-Aravind.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/