Re: [PATCH 1/8] ARM: at91: move peripheral id definitions to dt-bindingsinclude dir

[boris brezillon]

Hello Arnd,

On 07/08/2013 22:24, Arnd Bergmann wrote:
> On Thursday 01 August 2013, Boris BREZILLON wrote:
> > This patch moves peripheral id definitions from machine specific include
> > dir (arch/arm/mach-at91/include/mach/'soc-name'.h) to dt-bindinds include
> > dir (include/dt-bindings/at91/'soc-name'/peripherals.h).
> >
> > These definitions will be used inside dt to define interrupt ids and
> > peripheral clk ids.
> >
> > Signed-off-by: Boris BREZILLON <b.brezillon@xxxxxxxxxxx>
> This seems counterproductive, why would you do that?

This was requested by Jean-Christophe Plagniol-Villard (and proposed by 
Richard Genoud)
for the 3rd version of the "ARM: at91: move to common clk framework" 
patch series (see
https://lkml.org/lkml/2013/7/29/361) and thought it was a good idea too 
(even if I didn't know
where to put the macro files as there are no soc specific macro files in 
dt-bindings include
dir).

Indeed I found it much easier to detect bugs in dt definition using 
macros because
the macro names and dt node names are the same (it does not protect 
against errors
in the macro definitions).

If you think these macro definitions should be dropped, I won't argue 
against this.
But please, have a talk with Jean-Christophe first.

Best Regards,

Boris

> There is no sharing of identifiers across SoCs here, you just move the
> data around, and changing the .dts files to use the abstract macros would
> just end up making them harder to understand, not easier, since you then
> have to look up the numbers in another file.
>
> 	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/