Re: [PATCH v4 00/11] tracing: trace event triggers

[Steven Rostedt]

On Thu, 2013-08-08 at 11:02 +0900, Masami Hiramatsu wrote:

> # mkdir instances/hoge
> # echo 'enable_event:mce:mce_record' > instances/hoge/events/syscalls/sys_enter_symlink/trigger
> # cat instances/hoge/events/syscalls/sys_enter_symlink/enable
> 0*
> # cat instances/hoge/events/mce/mce_record/enable
> 0
> # cat events/mce/mce_record/enable
> 0*
> # ln -sf /dev/null /tmp
> # cat instances/hoge/events/mce/mce_record/enable
> 0
> # cat events/mce/mce_record/enable
> 1*
> 
> This looks odd, I expected enabling mce/mce_record under instances/hoge.
> 
> And, there is a bug of ftrace itself (not introduced by this series) I've found.
> After the above operation, we can delete the instance "hoge", but the soft-mode
> flag of mce_record is not cleared, even though there is no trigger referring
> the event.
> 
> # rmdir instances/hoge
> # cat events/mce/mce_record/enable
> 1*

Ouch. I'll have to look into this. Thanks!


> And also, could you rebase your patches on trace/for-next branch?
> Since that branch includes most of the latest fixes, it is better to
> review with it.

Yeah, it would be good to rebase against that. I may finally have time
to look into these patches.

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/