Re: linux-next: build failure after merge of the ext4 tree

From: Stephen Rothwell
Date: Wed Aug 07 2013 - 20:23:28 EST


Hi Kevin,

On Wed, 07 Aug 2013 08:28:35 -0700 Kevin Hilman
<khilman@xxxxxxxxxx> wrote:
>
> However, this same commit does introduce a new build failure (not
> present in next-20130806) when ext4 is built as a module:
>
> ERROR: "dirty_expire_interval" [fs/ext4/ext4.ko] undefined!
> make[3]: *** [__modpost] Error 1
> make[2]: *** [modules] Error 2
>
> The change below fixes the problem.
>
> Found when building the mv78xx0_defconfig on ARM.

OK, this raises an interesting question for me. Why does an x86_64
allmodconfig build build ext4 (amongst lots of other things) into the
kernel (instead of making them modules)?

Well, it seems that normally it doesn't. However when I do my
x86_64 allmodconfig builds, I set

CONFIG_PROFILE_ALL_BRANCHES=n
CONFIG_DEBUG_INFO=n
CONFIG_X86_DECODER_SELFTEST=n

via the KCONFIG_ALLCONFIG=<file> mechanism and that is enough to make
sure that CONFIG_MODULES=n - which is a bit self defeating for an
allmodconfig build. :-(

In fact, even giving an empty file to KCONFIG_ALLCONFIG= is enough to
turn CONFIG_MODULES off ...

These tests were done with Linus' tree of today (head commit b7bc9e7
"Merge tag 'trace-fixes-3.11-rc3' of
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace").

More quick testing with an empty file: v3.9 is OK, v3.10 gives
CONFIG_MODULES unset.
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature