Re: [PATCH 12/17] Add proper definitions for some EFI function pointers.

From: Roy Franz
Date: Wed Aug 07 2013 - 13:20:52 EST


On Wed, Aug 7, 2013 at 6:09 AM, Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:
> On Tue, 06 Aug, at 08:45:08PM, Roy Franz wrote:
>> The x86/AMD64 EFI stubs must us a call wrapper to convert between
>> the Linux and EFI ABIs, so void pointers are sufficient. For ARM,
>> the ABIs are compatible, so we can directly invoke the function
>> pointers. The functions that are used by the ARM stub are updated
>> to match the EFI definitions.
>>
>> Signed-off-by: Roy Franz <roy.franz@xxxxxxxxxx>
>> ---
>> include/linux/efi.h | 42 +++++++++++++++++++++++++-----------------
>> 1 file changed, 25 insertions(+), 17 deletions(-)
>>
>> diff --git a/include/linux/efi.h b/include/linux/efi.h
>> index 51f5641..96bb866 100644
>> --- a/include/linux/efi.h
>> +++ b/include/linux/efi.h
>> @@ -39,6 +39,8 @@
>> typedef unsigned long efi_status_t;
>> typedef u8 efi_bool_t;
>> typedef u16 efi_char16_t; /* UNICODE character */
>> +typedef u64 efi_physical_addr_t;
>> +typedef void *efi_handle_t;
>>
>>
>> typedef struct {
>> @@ -96,6 +98,7 @@ typedef struct {
>> #define EFI_MEMORY_DESCRIPTOR_VERSION 1
>>
>> #define EFI_PAGE_SHIFT 12
>> +#define EFI_PAGE_SIZE (1UL << EFI_PAGE_SHIFT)
>
> It would be worth getting rid of the EFI_PAGE_SIZE definition in
> arch/x86/boot/compressed/eboot.h now that we have one here.
>
> --
> Matt Fleming, Intel Open Source Technology Center

I'll get this in the next version.

Thanks,
Roy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/