Re: [PATCH v2 1/2] ALSA: Added jack detection KControl support

From: Mark Brown
Date: Wed Aug 07 2013 - 12:45:37 EST


On Fri, Aug 02, 2013 at 12:59:24AM -0700, Felipe F. Tonello wrote:

> +int jack_ctl_integer_info(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_info *uinfo)
> +{
> + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
> + uinfo->count = 0x10000U;
> + uinfo->value.integer.min = 0;
> + uinfo->value.integer.max = 0xffff;
> + return 0;
> +}

I'd expected to see us creating multiple boolean controls here. I don't
have a great problem with doing things this way but it's surprising and
I worry about confusing existing userspace, Takashi?

Attachment: signature.asc
Description: Digital signature