Re: [PATCH] clocksource: add an "menu" item to Kconfig

From: Sebastian Andrzej Siewior
Date: Wed Aug 07 2013 - 12:30:35 EST

On 08/07/2013 06:21 PM, John Stultz wrote:
> On 08/07/2013 03:56 AM, Sebastian Andrzej Siewior wrote:
>> This patch adds a menu item to clocksource' Kconfig file. Without it the
>> changeable items look somehow lost in the main drivers' menu
> So I'd like to push back on this a bit and ask why we need user-visible
> clocksource config options?

There was one visible Option if I remember correctly. I added two and
was wondering once I found them. I do have a PCI card which provides a
clock source and clock events device. So I assumed select <m|y> would
be doable.

> I'm much prefer the platform options select the needed clocksources, and
> not leave it up to the user (who really doesn't want to go digging
> around to find the clocksource sub-menu under drivers, and scan a list
> of 100 options that aren't possible on their hardware).
> For an example of what I consider bad behavior here, see the RTC driver
> directory - at a certain point they just become hashes: "Oh no.. you
> selected rtc-387aae6fd, on your hardware, you need rtc-adfb8e5".
> It really just seems like it forces more unnecessary options on the user
> and more ways to build a kernel that won't boot.
> I do get you're trying to fix up the bad situation, caused by
> user-prompts slipping into the Kconfig.

Yes, that is fine. That PCI device is divided into multiple devices so
once it is enabled I could use "select" for required clock source.

> But I might prefer a patch closer to whats below.


> thanks
> -john


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at