On Tuesday, August 06, 2013 08:08:20 AM Nishanth Menon wrote:change in subject to reflect new discussion.
On 05:53-20130806, Randy Dunlap wrote:On 08/03/2013 02:25 AM, Viresh Kumar wrote:
Though this has nothing specific with this patch, an interesting point.+EXPORT_SYMBOL_GPL(opp_add);
Could it be renamed to pm_opp_add() or power_opp_add() ?
The name is a bit too unspecific IMO.
git grep -w opp . showed drivers/tty/n_tty.c,
drivers/sbus/char/openprom.c and arch/powerpc/kvm/mpic.c using
variables named opp to mean what ever they had in context. rest(around
40 odd files) seem to use opp as in Documentation/power/opp.txt..
We could go with a pm_ prefix or even dev_pm_opp_ prefix to be more
specific, though I prefer just pm_. If Rafael and others are ok, I can
post a series out.
Yup, that would be useful. I'm for dev_pm_opp_ if that matters.