[PATCH] gpio: adnp: Fix segfault if request_threaded_irq fails

From: Lars Poeschel
Date: Wed Aug 07 2013 - 11:24:17 EST

From: Lars Poeschel <poeschel@xxxxxxxxxxx>

In case request_threaded_irq inside adnp_irq_setup fails, the driver
segfaults. This is because irq_domain_remove is called twice with
the same pointer. First time in adnp_irq_setup and then a second time
after leaving adnp_irq_setup in the error path of adnp_i2c_probe
inside adnp_teardown.
This fixes this by removing the call to irq_domain_remove from

Signed-off-by: Lars Poeschel <poeschel@xxxxxxxxxxx>
drivers/gpio/gpio-adnp.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c
index e60567f..c0f3fc4 100644
--- a/drivers/gpio/gpio-adnp.c
+++ b/drivers/gpio/gpio-adnp.c
@@ -490,15 +490,11 @@ static int adnp_irq_setup(struct adnp *adnp)
if (err != 0) {
dev_err(chip->dev, "can't request IRQ#%d: %d\n",
adnp->client->irq, err);
- goto error;
+ return err;

chip->to_irq = adnp_gpio_to_irq;
return 0;
- irq_domain_remove(adnp->domain);
- return err;

static void adnp_irq_teardown(struct adnp *adnp)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/