Re: [PATCH] mfd: ti_am335x_tscadc: fix spin lock and reg_cache

From: Lee Jones
Date: Wed Aug 07 2013 - 04:41:09 EST

On Mon, 05 Aug 2013, Zubair Lutfullah wrote:

> Reg_cache variable is used to lock step enable register
> from being accessed and written by both TSC and ADC
> at the same time.
> However, it isn't updated anywhere in the code at all.
> If both TSC and ADC are used, eventually 1FFFF is always
> written enabling all 16 steps uselessly causing a mess.
> Patch fixes it by correcting the locks and updates the
> variable by reading the step enable register
> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@xxxxxxxxx>
> ---
> drivers/mfd/ti_am335x_tscadc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Better that it comes from somewhere.

Applied, thanks.

Lee Jones
Linaro ST-Ericsson Landing Team Lead â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at