Re: [PATCH V9 08/14] perf tools: move struct ip_event

[Namhyung Kim]

On Mon,  5 Aug 2013 19:26:28 +0300, Adrian Hunter wrote:
> struct ip_event assumes fixed positions for ip, pid
> and tid.  That is no longer true with the addition of
> PERF_SAMPLE_IDENTIFIER.
>
> struct ip_event is no longer used except by hists_link.c.
> Move it there.

I think you can just get rid of ip_event and fill sample->ip/pid from
fake_common_samples directly.  The reason of using ip_event was because
it's used in perf_event__preprocess_sample() but you've removed it. :)

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/