Re: [PATCH] checkpatch: Better --fix of SPACING errors.

From: Joe Perches
Date: Wed Aug 07 2013 - 00:00:22 EST

On Tue, 2013-08-06 at 19:55 -0700, Joe Perches wrote:
> Previous attempt at fixing SPACING errors could
> make a hash of several defects.

I have run this against drivers/staging/...

It works rather better than the older version.

It does have an issue with c99 style comments
when it needs to rewrite spacing as well.

If you use this with -f, please convert the
c99 // comments to /* ... */ first using the
--types c99_comments option,

Maybe use:

$ ./scripts/ -f --fix --types=c99_comments <file>
$ mv <file>.EXPERIMENTAL-checkpatch-fixes <file>
$ ./scripts/ -f --fix --types=spacing <file>
$ mv <file>.EXPERIMENTAL-checkpatch-fixes <file>
$ git diff <file>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at