Re: [PATCH aio-next] aio: fix error handling and rcu usage in "convert the ioctx list to table lookup v3"

From: Benjamin LaHaise
Date: Tue Aug 06 2013 - 20:52:13 EST

On Tue, Aug 06, 2013 at 05:57:32PM -0400, Sasha Levin wrote:
> Old error is gone, but now seeing this, which seems related.
> ctx = table->table[id];
> if (ctx->user_id == ctx_id) { <--- here
> percpu_ref_get(&ctx->users);
> ret = ctx;
> }

Why am I not surprised. That should be fixed with the patch below. I'll
post some patches for the libaio test suite tomorrow to check these cases
explicitly and scan for any others that need to be added. Thanks again,

"Thought is the essence of where you are now."

diff --git a/fs/aio.c b/fs/aio.c
index 3bc068c..c3f005d 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -812,7 +812,7 @@ static struct kioctx *lookup_ioctx(unsigned long ctx_id)
goto out;

ctx = table->table[id];
- if (ctx->user_id == ctx_id) {
+ if (ctx && ctx->user_id == ctx_id) {
ret = ctx;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at