Re: [PATCH 0/2] kernel/sys.c: for setfsgid(), return the current gidwhen error occurs

From: Kees Cook
Date: Tue Aug 06 2013 - 14:36:49 EST

On Tue, Aug 6, 2013 at 1:00 AM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> They are 2 related patches for setfsgid().
> Patch 1 for bug fix: return the current gid when error occurs.
> Patch 2 for cleaning code: remove useless variable 'old_fsgid'.
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
> --
> kernel/sys.c | 15 +++++----------
> 1 files changed, 5 insertions(+), 10 deletions(-)

Making a change like this might have dramatic effects. So, a few
questions, to help better understand:

How long as the behavior been this way on Linux?
What is the origin of the documentation that states it differently?
Do existing userspace tools already depend on the current behavior?
What specific problem will be solved by changing this?



Kees Cook
Chrome OS Security
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at