Re: [PATCH 0/9] perf tools: Enhance and correct srcline behavior

[Jiri Olsa]

On Thu, Aug 01, 2013 at 11:55:35AM +0900, Namhyung Kim wrote:
> Hello,
> 
> This patchset tries to fix and enhance current srcline behavior.
> 
> Firstly it doesn't actually sort by srcline info but by ip.  I suspect
> it was because of a performance reason to run external addr2line
> utility.  It showed the srcline info after hist entries were
> collapsed.  Thanks to Roberto, we now have internal implementation of
> addr2line using libbfd so can sort/compare by srcline of entries.
> 
> Second problem for me was it sometimes printed "??:0" and sometimes
> printed a raw ip value for unknown srcline info.  I changed to print
> the former consistently.
> 
> While at it, I found some bugs/leaks in srcline handling.  Patch 1-3
> are fixes for those and can be merged separately.
> 
> You can get this series on my 'perf/srcline-v1' branch in my tree at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> Any comments are welcome, thanks.
> Namhyung
> 
> 
> Namhyung Kim (8):
>   perf sort: Fix a memory leak on srcline
>   perf annotate: Reuse path from the result of addr2line
>   perf hists: Free srcline when freeing hist_entry
>   perf tools: Factor out get/free_srcline()
>   perf tools: Do not try to call addr2line for non-binary files
>   perf tools: Pass dso instead of dso_name to get_srcline()
>   perf tools: Save failed result of get_srcline()
>   perf tools: Fix srcline sort key behavior
> 
> Roberto Vitillo (1):
>   perf tools: Implement addr2line directly using libbfd
> 

nice..

Reviewed-by: Jiri Olsa <jolsa@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/