RE: [PATCH 1/1] checkpatch: fix some whitespace issues caused by --fix

From: Phil Carmody
Date: Tue Aug 06 2013 - 04:06:07 EST

> On Mon, 2013-08-05 at 14:08 +0300, Phil Carmody wrote:
> > Lines with incorrect spacing around an operator, such as:
> > bystander, correct,incorrect
> > would get "fixed" to
> > bystander,correct, incorrect
> > as the correct argument as well as the incorrectly-spaced operator
> > were both being trimmed. The correct argument only needs to be right
> > trimmed.
> Thanks for the patch, but I think it needs a different fix.

I think it's the right approach, but you're right, it doesn't
fix all the problems. However, in part that's because many
copies of the string, or bits of it, are created, and when
one copy is modified, the others don't replicate that change.

> Even after your patch the --fix option still makes a mess of several
> code spacing issues.

Indeed. Just seen - func(foo,&bar); becoming func(foo, &bar);,
as --fix wants to put a space both after the ',' and before the '&'.

> I'll work on it and propose something soonish.

It's very much a WIP - I'll send my bride-of-checkpatch to you
as soon as I've written some blurb. It might be that the
complexities inside checkpatch can't be overcome, and it's
easier to address the changes entirely in a separate script?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at