[PATCH 2/5] ACPI: Create symlinks in acpi_bind_one() under physical_node_lock

From: Rafael J. Wysocki
Date: Mon Aug 05 2013 - 20:22:04 EST


From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Put the creation of symlinks in acpi_bind_one() under the
physical_node_lock mutex of the given ACPI device objects, because
that is part of the binding operation logically (those links are
already removed under that mutex too).

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
drivers/acpi/glue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/acpi/glue.c
===================================================================
--- linux-pm.orig/drivers/acpi/glue.c
+++ linux-pm/drivers/acpi/glue.c
@@ -177,8 +177,6 @@ int acpi_bind_one(struct device *dev, ac
list_add(&physical_node->node, physnode_list);
acpi_dev->physical_node_count++;

- mutex_unlock(&acpi_dev->physical_node_lock);
-
if (!ACPI_HANDLE(dev))
ACPI_HANDLE_SET(dev, acpi_dev->handle);

@@ -188,6 +186,8 @@ int acpi_bind_one(struct device *dev, ac
retval = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj,
"firmware_node");

+ mutex_unlock(&acpi_dev->physical_node_lock);
+
if (acpi_dev->wakeup.flags.valid)
device_set_wakeup_capable(dev, true);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/