Re: [PATCH 08/16] x86, asmlinkage, kexec: Drop bogus asmlinkage inmachine_kexec_32

From: H. Peter Anvin
Date: Mon Aug 05 2013 - 19:03:51 EST

On 08/05/2013 03:02 PM, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> A function pointer cannot be asmlinkage. Just drop it.
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Eh? It certainly matters for the function pointer if it is regparm(0)
or regparm(3), and the pointed-to function definitely assumes
regparm(0). So I think this patch is wrong, and if it isn't, it
definitely needs better explanation why it isn't wrong.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at