Re: [PATCH V2 2/3] pinctrl: pinconf-generic: add generic APIs formapping pinctrl node

[Stephen Warren]

On 08/05/2013 01:33 AM, Laxman Dewangan wrote:
> Add generic APIs to map the DT node and its sub node in pinconf generic
> driver. These APIs can be used from driver to parse the DT node who

> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> index aeb3c99..52fb521 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> @@ -174,3 +174,19 @@ All parameters not listed here, do not take an argument.
>  
>  More in-depth documentation on these parameters can be found in
>  <include/linux/pinctrl/pinconfig-generic.h>
> +
> +Generic pinconfig option also support the defining of pins and functions.
> +The properties are:
> +pinctrl-pins: This property tells the name of pins or list of pins for which
> +  configuration is needed. The valid pin names are device/chip specific and
> +  it can be found from the device/chip specific binding documents.
> +pinctrl-function: This property tells the configuration of the pins on to the
> +  given function. The valid functions are device/chip specific and it can be
> +  found from the device/chip specific binding documents.

This text feels like it's just been bolted on the end rather than
integrated into the existing description of generic pinconfig options.
Also, the existing text for generic pinconfig options doesn't feel at
all right to me. I'll send a patch to clean that up, and integrate these
new properties.

I would name the new properties just pins and functions, given their
scope is explicitly limited to pinctrl configuration nodes, so
"pinctrl-" is a little redundant.

With the properties renamed, and this patch rebased on top of the patch
I'll send out later, this patch,
Reviewed-by: Stephen Warren <swarren@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/