Re: [RFC] gcc feature request: Moving blocks into sections

From: Linus Torvalds
Date: Mon Aug 05 2013 - 15:25:45 EST


On Mon, Aug 5, 2013 at 12:04 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> Steven Rostedt <rostedt@xxxxxxxxxxx> writes:
>
> Can't you just use -freorder-blocks-and-partition?
>
> This should already partition unlikely blocks into a
> different section. Just a single one of course.

That's horrible. Not because of dwarf problems, but exactly because
unlikely code isn't necessarily *that* unlikely, and normal unlikely
code is reached with a small branch. Making it a whole different
section breaks both of those.

Maybe some "really_unlikely()" would make it ok.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/