Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S

[David Daney]

On 08/05/2013 06:43 AM, Gleb Natapov wrote:
> On Mon, Aug 05, 2013 at 03:21:57PM +0200, Ralf Baechle wrote:
> > On Mon, Aug 05, 2013 at 02:17:01PM +0100, James Hogan wrote:
> >
> > > On 01/08/13 21:22, David Daney wrote:
> > > > From: David Daney <david.daney@xxxxxxxxxx>
> > > >
> > > > No code changes, just reflowing some comments and consistently using
> > > > tabs and spaces.  Object code is verified to be unchanged.
> > > >
> > > > Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
> > > > Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> > >
> > >
> > > > +   	 /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */
> > >
> > > git am detects a whitespace error here ("space before tab in indent").
> > > It's got spaces before and after the tab actually.
> > >
> > > >       /* load the guest context from VCPU and return */
> > >
> > > this comment could have it's indentation fixed too
> > >
> > > Otherwise, for all 3 patches:
> > >
> > > Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>
> >
> > I'm happy with the patch series as well and will fix this issue when
> > applying the patch.
> kvm fixes usually go through kvm.git tree for all arches. Any special
> reasons you want to get those through mips tree?

I don't really care which tree takes this particular patch set.

However, in the near future, I will be sending revised versions of 
patches needed by MIPS/KVM that are in files outside of the 
arch/mips/kvm directory and it is possible that those may suffer patch 
ordering problems if merged through a 'foreign tree'.

In any event, there is the problem with the whitespace error in the 
comment.  I blame checkpatch.pl for not flagging it, but that is not 
really a good excuse.  If it goes by the KVM tree, do you want me to 
send a corrected patch?  Or can you fix it when you merge it.

David Daney

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/